Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade RN Storybook/addons from next(v6.0.1-alpha.7) to v6.0.1-beta.6 #764

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

leotm
Copy link
Owner

@leotm leotm commented Jul 12, 2022

Fix: #616

Some left on @next if Yarn unable to find v6.0.1-beta.6

Note RN Storybook

  • v5.3: /stories, w static analysis (remove or refactor)
  • v6: .storybook, w minimal config w/o stories

Note Jest setup mocks

  • @storybook/addon-ondevice-notes/register parsing issue
  • @storybook/addon-actions ES forEach proto parsing issue

StorybookUIRoot

  • static analysis passing
  • Jest snapshot passing w StorybookUIRoot and mocks

Fix: #616

Some left on `@next` if Yarn unable to find v6.0.1-beta.6

Note RN Storybook
- v5.3: /stories, w static analysis (remove or refactor)
- v6: .storybook, w minimal config w/o stories

Note Jest setup mocks
- @storybook/addon-ondevice-notes/register parsing issue
- @storybook/addon-actions ES forEach proto parsing issue

StorybookUIRoot
- static analysis passing
- Jest snapshot passing w StorybookUIRoot and mocks
@leotm leotm added storybook Storybook changes new arch Fabric / TurboModules / JSI changes hermes JS engine for RN (optimised: TTI, size, RAM) p: Facebook Partner: Meta p: Storybook labels Jul 12, 2022
@leotm leotm added this to the Storybook v6 beta milestone Jul 12, 2022
@leotm leotm marked this pull request as ready for review July 12, 2022 18:52
@leotm leotm merged commit 86af64b into master Jul 12, 2022
@leotm leotm deleted the storybook-6.0.1-beta.6 branch July 12, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hermes JS engine for RN (optimised: TTI, size, RAM) new arch Fabric / TurboModules / JSI changes p: Facebook Partner: Meta p: Storybook storybook Storybook changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix RN w Storybook v6a and upg to v6b
1 participant