Add the gazelle plugin to the distribution (#400) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the gazelle plugin to the distribution
To avoid everyone needing to take a dep on `rules_go`, we
do the following:
1. Regular Bazel users need to load `bazel_skylib_gazelle_plugin_workspace`
and call that, and then `bazel_skylib_gazelle_plugin_setup`
2. `bzlmod` users need do nothing, but we now include the
`rules_go` dep in the `MODULE.bazel` shipped in the release.
This is fine, because `bzlmod` will lazily load
dependencies.
* Run buildifier
* Add docstring to `gazelle_setup.bzl`
* Move "internal only" marker
* Make @com_github_bazelbuild_buildtools visible in the deployed module
* Respond to review comments
* Move plugin to a nested workspace
* Run buildifier
* Restore the module declaration from `main`
* Bump versions of rules_go and gazelle used in the top-level module to match the ones in gazelle
* Respond to review comments and add gazelle to ignored directories so //... works as expected
* Add missing descriptor for stardoc
* Move gazelle hints into workspace files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid everyone needing to take a dep on
rules_go, we do the following:Regular Bazel users need to load
bazel_skylib_gazelle_plugin_workspaceand call that, and thenbazel_skylib_gazelle_plugin_setupbzlmodusers need do nothing, but we now include therules_godep in theMODULE.bazelshipped in the release. This is fine, becausebzlmodwill lazily load dependencies.Run buildifier
Add docstring to
gazelle_setup.bzlMove "internal only" marker
Make @com_github_bazelbuild_buildtools visible in the deployed module
Respond to review comments
Move plugin to a nested workspace
Run buildifier
Restore the module declaration from
mainBump versions of rules_go and gazelle used in the top-level module to match the ones in gazelle
Respond to review comments and add gazelle to ignored directories so //... works as expected
Add missing descriptor for stardoc
Move gazelle hints into workspace files