Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nvidia/nvml): update nvlib to 0.7.0, rename device ID fields #114

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Oct 11, 2024

@gyuho gyuho self-assigned this Oct 11, 2024
gyuho added 2 commits October 11, 2024 12:00
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho gyuho changed the title feat(nvidia/nvml): fabric attached info per device, update nvlib 0.7.0 feat(nvidia/nvml): update nvlib to 0.7.0, rename device ID fields Oct 11, 2024
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho gyuho added this to the v0.0.5 milestone Oct 11, 2024
Copy link
Contributor

@photoszzt photoszzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this PR for some other commits? I don't see a place that uses warningBlackSign.

components/accelerator/nvidia/query/query.go Outdated Show resolved Hide resolved
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho gyuho merged commit 91827df into main Oct 14, 2024
5 checks passed
@gyuho gyuho deleted the update-dep-nvidia-and-others branch October 14, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants