Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nvml): handle "not supported" error to not fail-fast for NVML get calls #291

Merged
merged 13 commits into from
Jan 10, 2025
Merged

fix(nvml): handle "not supported" error to not fail-fast for NVML get calls #291

merged 13 commits into from
Jan 10, 2025

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Jan 9, 2025

No description provided.

@gyuho gyuho self-assigned this Jan 9, 2025
@gyuho gyuho mentioned this pull request Jan 9, 2025
Merged
cardyok
cardyok approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@cardyok cardyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one question, in general,
seems changing ret != nvml.SUCCESS -> IsNotSupportError(ret) ignores errors other than not supported, will this cause unexpected behavior?

gyuho added a commit that referenced this pull request Jan 10, 2025
@gyuho
fix(ci): bump up linux header deps (#292)
965cb60 
Fix CI failures in #291

---------

Signed-off-by: Gyuho Lee <[email protected]>
gyuho added 13 commits January 10, 2025 18:29
@gyuho
fix(nvml): use "not supported" error for getGspFirmwareMode calls
6711782 
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
fix(nvml): clock events to return "supported" boolean on "not support…
79bacb4 
…ed" error

Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
fix(nvml): set "supported" boolean on clock speed "not supported" err…
5e4a7e1 
…or return

Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
clock events/speed to handle not supported errors
70512d1 
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
fix(nvml): handle not supported error for persistence mode, power, pr…
d7c01a7 
…ocess, remapped rows, util, xid nvml calls

Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
fix(nvml): handle not supported error for ecc mode
3eb02e7 
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
fix errors
41ad49a 
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
fix(nvml): handle not supported error for nvlink
4ea1941 
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
fix(memory): handle not supported error
28ed3ff 
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
fix(nvml): handle "not supported" error for gpm
a04d999 
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
fix(nvml): handle "not supported" error for ecc errors calls
c2dd4a6 
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
join errors
9bc54f4 
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
wrap errors
5e398f3 
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho gyuho force-pushed the gsp-firmware-error-handling-plus-nvml branch from 35ed448 to 5e398f3 Compare January 10, 2025 10:29
@gyuho
Copy link
Collaborator Author

gyuho commented Jan 10, 2025

ret != nvml.SUCCESS

This will fail since the ret is nvml NOT SUPPORTED from NVML call, we want to return no error if it's not supported

@gyuho gyuho merged commit b794199 into main Jan 10, 2025
4 checks passed
@gyuho gyuho deleted the gsp-firmware-error-handling-plus-nvml branch January 10, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardyok cardyok cardyok approved these changes

Assignees

@gyuho gyuho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gyuho @cardyok