fix(*): add missing close on process that runs commands as bash, rename abort to close #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any way we can test this? |
|
need to have unit test or end to end test to ensure there is no leak |
gyuho
changed the title
gyuho
force-pushed
the
add-missing-abort
branch
2 times, most recently
from
751d553 to
a8001ef
Compare
|
lgtm. defer to @cardyok |
…me abort to close > open /tmp/tmpbash888507873.bash: too many open files Signed-off-by: Gyuho Lee <[email protected]>
gyuho
force-pushed
the
add-missing-abort
branch
2 times, most recently
from
f26b07b to
a853195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix