Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nvidia): do not set infiniband expected ports default #295

Closed
wants to merge 1 commit into from
Closed

feat(nvidia): do not set infiniband expected ports default #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/accelerator/nvidia/infiniband/component_output.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
nvidia_query "github.com/leptonai/gpud/components/accelerator/nvidia/query"
"github.com/leptonai/gpud/components/accelerator/nvidia/query/infiniband"
"github.com/leptonai/gpud/components/common"
"github.com/leptonai/gpud/log"
)

// ToOutput converts nvidia_query.Output to Output.
Expand Down Expand Up @@ -120,7 +121,7 @@ func (o *Output) Evaluate(cfg Config) (string, bool, error) {

// some H100 machines only have 1 ib port in ib class dir
if atLeastPorts == 0 {
atLeastPorts = infiniband.CountInfinibandClass()
log.Logger.Warnw("no at least ports set -- skipping ibstat check", "infinibandClassCount", infiniband.CountInfinibandClass())
}

// H100 machines with 12 ib ports should default to the GPU count 8
Expand Down
Loading