Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Google Cloud Storage #15

Merged
merged 2 commits into from
May 10, 2022
Merged

Conversation

leshchenko1979
Copy link
Owner

Fixes #3

@sourcery-ai
Copy link

sourcery-ai bot commented May 10, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.07%.

Quality metrics Before After Change
Complexity 0.98 ⭐ 0.93 ⭐ -0.05 👍
Method Length 32.50 ⭐ 27.26 ⭐ -5.24 👍
Working memory 4.70 ⭐ 4.62 ⭐ -0.08 👍
Quality 87.28% 88.35% 1.07% 👍
Other metrics Before After Change
Lines 696 792 96
Changed files Quality Before Quality After Quality Change
perscache/cache.py 76.57% ⭐ 76.57% ⭐ 0.00%
perscache/storage.py 82.50% ⭐ 93.27% ⭐ 10.77% 👍
tests/conftest.py 99.33% ⭐ 99.33% ⭐ 0.00%
tests/test_change.py 91.56% ⭐ 91.56% ⭐ 0.00%
tests/test_main.py 94.27% ⭐ 96.22% ⭐ 1.95% 👍
tests/test_storage.py 84.50% ⭐ 83.59% ⭐ -0.91% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
perscache/cache.py _CachedFunction.__call__ 10 🙂 211 ⛔ 9 🙂 49.96% 😞 Try splitting into smaller methods
perscache/cache.py Cache.__call__ 5 ⭐ 68 🙂 11 😞 66.80% 🙂 Extract out complex expressions
tests/test_storage.py cache 2 ⭐ 56 ⭐ 11 😞 71.64% 🙂 Extract out complex expressions
perscache/cache.py Cache._get_key 1 ⭐ 54 ⭐ 10 😞 74.85% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@leshchenko1979 leshchenko1979 merged commit c3b03f1 into master May 10, 2022
@leshchenko1979 leshchenko1979 deleted the leshchenko1979/issue3 branch May 10, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP Storage
1 participant