Skip to content

Commit

Permalink
fixes #289
Browse files Browse the repository at this point in the history
  • Loading branch information
letsar committed Jul 10, 2022
1 parent 566e358 commit 3da1f0a
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 15 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.3.1
### Fixed
* Rare LateInitializationError with DrawerMotion (https://github.com/letsar/flutter_slidable/issues/289).

## 1.3.0
### Added
* Padding and BorderRadius to SlidableAction.
Expand Down
2 changes: 1 addition & 1 deletion example/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ packages:
path: ".."
relative: true
source: path
version: "1.3.0"
version: "1.3.1"
flutter_test:
dependency: "direct dev"
description: flutter
Expand Down
29 changes: 16 additions & 13 deletions lib/src/flex_entrance_transition.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import 'package:flutter/widgets.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter/widgets.dart';

// INTERNAL USE
// ignore_for_file: public_member_api_docs
Expand Down Expand Up @@ -42,7 +42,7 @@ class FlexEntranceTransition extends MultiChildRenderObjectWidget {
}

class _FlexEntranceTransitionParentData extends FlexParentData {
late Tween<double> mainAxisPosition;
Tween<double>? mainAxisPosition;
}

class _RenderFlexEntranceTransition extends RenderBox
Expand Down Expand Up @@ -123,17 +123,20 @@ class _RenderFlexEntranceTransition extends RenderBox
}

void updateChildOffsets(RenderObject child) {
final parentData = child.parentData as _FlexEntranceTransitionParentData?;
final mainAxisPosition = parentData!.mainAxisPosition.evaluate(
_mainAxisPosition,
);
switch (_direction) {
case Axis.horizontal:
parentData.offset = Offset(mainAxisPosition, 0);
break;
case Axis.vertical:
parentData.offset = Offset(0, mainAxisPosition);
break;
final parentData = child.parentData;
if (parentData is _FlexEntranceTransitionParentData) {
final mainAxisPosition = parentData.mainAxisPosition?.evaluate(
_mainAxisPosition,
) ??
0;
switch (_direction) {
case Axis.horizontal:
parentData.offset = Offset(mainAxisPosition, 0);
break;
case Axis.vertical:
parentData.offset = Offset(0, mainAxisPosition);
break;
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: flutter_slidable
description: A Flutter implementation of slidable list item with directional slide actions that can be dismissed.
version: 1.3.0
version: 1.3.1
homepage: https://github.com/letsar/flutter_slidable

environment:
Expand Down

0 comments on commit 3da1f0a

Please sign in to comment.