-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin P025 (ADS1115) problem with decimal places in formula calculation. #5123
Comments
Yep, seems like the decimals are applied before the formula is applied. Will have a look at it. |
I added a quick fix, can you test it when this GH Actions build is ready? |
OK, so maybe I should spend more than half an hour on it ;) |
Should be fixed with this build: https://github.com/letscontrolit/ESPEasy/actions/runs/10874920584 (when ready) |
It seems to be OK now. |
Which build is this? Is the flash file system full? |
Update to the version you provided in the link: |
ESP32 or ESP8266? |
still the same ESP32-C3 SPIFFS normal |
Can you try with this build I made last night? This does contain some fixes I submitted to the Arduino code last week regarding flushing of stream objects, some issues in Webserver and some other minor fixes. I just tested it on an ESP32-classic running this build and there I can just save the settings (tested on LittleFS builds, will now also flash a SPIFFS build to test) Edit: Tried also a SPIFFS build on this ESP32-classic. |
Hmm this sounds like your device has issues writing to the flash. |
How full is your file system? |
2 options worth investigating:
|
I am working on SPIFFS after previous problems with WiFI that occurred on LittleFS and ESP32-C3 one more thing - I cannot change some settings in the task, e.g. Decimals in Formula, instead of saving it restores the previous state |
A few more things to check:
|
OK, it looks like the ESP somehow can't save the settings. What do you have stored on the file system? |
Ok test of the third, new esp without any configuration. test: enabling Rules and attempting to create a task (Switch input - Switch/ GPIO2) installation from 20240822 - |
OK, so there is something wrong here... |
is it possible to send you a private message? |
I think I may have found the issue... And since we're using this |
I'm glad you managed to figure something out. I may not be the best programmer, but lately I've been coming across and helping to find a lot of bugs in various projects I work with. |
That's also really important. |
That's very helpful, real world usage is a great way to test stuff, although it can be quite frustrating if something doesn't work as intended. |
You're welcome. I'll remind myself if #4969 there's a chance that this will be created ? Tasmota also already supports BLE sensors. |
Right now there are just too many open issues which need to be dealt with. |
@TD-er position() method is also used on available() and peek() |
Thanks, I was wondering why it wasn't fixed with my local changes |
OK, took quite some effort to get this bug and the rules editing one fixed using IDF5.3 |
I tested it, it looks OK |
I measure voltage using ADS1115. Due to the fact that the voltage range is above 30V I have used a resistive voltage divider 1:10
I select the Convert to Volt option:
Therefore, the voltage of 12.7V measured by ADS1115 is as 1.27V.
I want ESP to display the original voltage of 12.6V so I multiply:
%value%*10
and I should get 12.7V with Decimals set to 1
unfortunately I get 13.0V
the images show the version with multiplied * 10 and without the formula:
It looks like the Decimals parameter is used for the value of the input parameter %value%, not for the result of the entire formula.
So
1.27 -> 1.3
1.3*10=13.0V
it looks even worse after multiplying *100
ESP type: ESP32-C3
Build version: ESP_Easy_mega_20240902_normal_ESP32c3_4M316k_CDC
The text was updated successfully, but these errors were encountered: