Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement clean shutdowns for gRPC #1900

Closed
jsha opened this issue Jun 7, 2016 · 3 comments
Closed

Implement clean shutdowns for gRPC #1900

jsha opened this issue Jun 7, 2016 · 3 comments
Labels
layer/rpc status/blocked/dep

Comments

@jsha
Copy link
Contributor

jsha commented Jun 7, 2016 •
edited
Loading

A gRPC server that receives TERM should be able to tell its clients "don't send me any new requests," finish any pending requests it has, and then exit.
@jsha
Copy link
Contributor Author

jsha commented Jun 14, 2016

Upstream issue: grpc/grpc-go#147

@jsha
Copy link
Contributor Author

jsha commented Jun 21, 2016

We should do some testing with synthetically long-lived requests. Maybe if we start doing fail-fast on inbound requests clients will just retry on another host, and we don't need a GOAWAY frame. However, if that doesn't work for us, we may want to consider implementing something upstream.

@rolandshoemaker
Copy link
Contributor

Closed by #2333.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
layer/rpc status/blocked/dep
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsha @rolandshoemaker