Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support graceful server shutdown #147

Closed
iamqizhao opened this issue Apr 1, 2015 · 4 comments · Fixed by #774
Closed

Support graceful server shutdown #147

iamqizhao opened this issue Apr 1, 2015 · 4 comments · Fixed by #774
Milestone
GA

Comments

@iamqizhao
Copy link
Contributor

A server that is attempting to gracefully shut down a
connection SHOULD send an initial GOAWAY frame with the last stream
identifier set to 2^31-1 and a NO_ERROR code. This signals to the
client that a shutdown is imminent and that no further requests can
be initiated. After waiting at least one round trip time, the server
can send another GOAWAY frame with an updated last stream identifier.
This ensures that a connection can be cleanly shut down without
losing requests.
@mwitkow
Copy link
Contributor

mwitkow commented Aug 3, 2015

Nice to see lameduck mode being planned :)
Are you guys planning in any way to bridge it with other mechanisms, such as:
https://github.com/facebookgo/grace

@mwitkow
Copy link
Contributor

mwitkow commented Nov 10, 2015

@iamqizhao, can you provide any tips as to how to get started here? Is the logic inside http2Server?

@dsymonds dsymonds mentioned this issue Dec 4, 2015
Closed
@iamqizhao iamqizhao added this to the 2016/02/15 Milestone milestone Jan 12, 2016
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Jan 31, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
a06f8f0 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 1, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
a4a61af 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
@bradfitz bradfitz mentioned this issue Feb 1, 2016
Merged
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 1, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
20d0619 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 1, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
85d0357 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 4, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
31ff71d 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 4, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
eeff984 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 4, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
e836862 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 5, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
1e2a9c2 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 8, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
737fff1 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 9, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
cc3cd51 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 9, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
d1f014c 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 9, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
fc6ebf5 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
@iamqizhao iamqizhao mentioned this issue Feb 9, 2016
Closed
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 9, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
8c9ca55 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 10, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
61d3357 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 11, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
eb0e517 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 11, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
81d512c 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 11, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
d0f39dd 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 12, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
7346c87 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
@bobbytables
Copy link

Is there anything I can do to help with this? I'm also looking for a way to gracefully shutdown a grpc server.

@jsha jsha mentioned this issue Jun 14, 2016
Closed
@frosenberg
Copy link

What is the status of this item?

@jayantkolhe jayantkolhe modified the milestones: GA, 2016/02/15 Milestone Jul 13, 2016
@iamqizhao iamqizhao mentioned this issue Jul 22, 2016
Merged
@MakMukhi MakMukhi mentioned this issue Jul 25, 2017
Closed
@bbeaudreault bbeaudreault mentioned this issue Aug 12, 2017
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
GA
Development

Successfully merging a pull request may close this issue.

Support server graceful shutdown iamqizhao/grpc-go
5 participants
@bobbytables @frosenberg @jayantkolhe @mwitkow @iamqizhao