Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme update and tooling fixes #1

Merged
merged 9 commits into from
Aug 11, 2022
Merged

Readme update and tooling fixes #1

merged 9 commits into from
Aug 11, 2022

Conversation

pgporada
Copy link
Member

No description provided.

jcjones
jcjones requested changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@jcjones jcjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than long-lived folders with .gitkeep, maybe either:

  1. Pull the CT data from the current logs and store it here, for easier analysis and diffing
  2. Switch to mktemp for the outputs rather than these git-controlled subfolders, which gives nicer diffing

@pgporada pgporada requested a review from jcjones July 26, 2022 20:32
jcjones
jcjones requested changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@jcjones jcjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's switch to having one dir per log, rather than per log shard

tooling/diff_accepted_roots.sh Outdated Show resolved Hide resolved
@jcjones jcjones mentioned this pull request Aug 11, 2022
Open
jcjones
jcjones approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@jcjones jcjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shed is a fine color and I would put my bike in it.

I did open #3 with a suggestion for future improvement.

@pgporada pgporada merged commit 855ea85 into main Aug 11, 2022
@pgporada pgporada deleted the update-docs branch August 11, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcjones jcjones jcjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgporada @jcjones