Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check out Certbot and run chisel2 against Pebble. #15

Merged
merged 2 commits into from
Mar 20, 2017
Merged

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Mar 17, 2017

No description provided.

@jsha jsha requested a review from cpu March 17, 2017 22:24
.travis.yml Outdated
- until </dev/tcp/localhost/14000 ; do sleep 0.1 ; done

script:
- python ./certbot/tools/chisel2.py $(openssl rand -hex 3).127.0.0.1.ipna.me $(openssl rand -hex 3).127.0.0.1.ipna.me
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use ipna.me domains here? Any particular reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to implement a fake DNS thing, so I needed something that would resolve to 127.0.0.1. This was a handy one. We could alternately install dnsmasq as part of the Travis setup.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpu cpu merged commit 7142cb8 into master Mar 20, 2017
mcpherrinm pushed a commit to mcpherrinm/pebble that referenced this pull request May 24, 2024
Go's ListenAndServe methods return an error with the text "Server
close", even on a clean shutdown. We should suppress this spurious error
so it doesn't mask more meaningful ones.

Also, update to a more recent golangci-lint and exempt some lints in order
to fix the build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants