Tread-safe track having per-worker statistics

levaitamas · Jul 25, 2018 · 133a2d1 · 133a2d1
1 parent 5d9f212
commit 133a2d1
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 15 deletions.
diff --git a/core/gate_hooks/track.cc b/core/gate_hooks/track.cc
@@ -44,33 +44,32 @@ const GateHookCommands Track::cmds = {{"reset", "EmptyArg",
 Track::Track()
     : bess::GateHook(Track::kName, Track::kPriority),
       track_bytes_(),
-      cnt_(),
-      pkts_(),
-      bytes_() {}
+      worker_stats_() {}
 
 CommandResponse Track::Init(const bess::Gate *, const bess::pb::TrackArg &arg) {
   track_bytes_ = arg.bits();
   return CommandSuccess();
 }
 
 CommandResponse Track::CommandReset(const bess::pb::EmptyArg &) {
-  cnt_ = 0;
-  pkts_ = 0;
-  bytes_ = 0;
+  worker_stats_ = {};
   return CommandSuccess();
 }
 
 void Track::ProcessBatch(const bess::PacketBatch *batch) {
+
+  TrackStats *stat = &worker_stats_[current_worker.wid()];
+
   size_t cnt = batch->cnt();
-  cnt_ += 1;
-  pkts_ += cnt;
+  stat->cnt += 1;
+  stat->pkts += cnt;
 
   if (!track_bytes_) {
     return;
   }
 
   for (size_t i = 0; i < cnt; i++) {
-    bytes_ += batch->pkts()[i]->data_len() + kEthernetOverhead;
+    stat->bytes += batch->pkts()[i]->data_len() + kEthernetOverhead;
   }
 }
 

diff --git a/core/gate_hooks/track.h b/core/gate_hooks/track.h
@@ -43,11 +43,29 @@ class Track final : public bess::GateHook {
 
   CommandResponse Init(const bess::Gate *, const bess::pb::TrackArg &);
 
-  uint64_t cnt() const { return cnt_; }
+  uint64_t cnt() const {
+    uint64_t cnt = 0;
+    for (int i = 0; i < Worker::kMaxWorkers; i++) {
+      cnt += worker_stats_[i].cnt;
+    }
+    return cnt;
+  }
 
-  uint64_t pkts() const { return pkts_; }
+  uint64_t pkts() const {
+    uint64_t pkts = 0;
+    for (int i = 0; i < Worker::kMaxWorkers; i++) {
+      pkts += worker_stats_[i].pkts;
+    }
+    return pkts;
+  }
 
-  uint64_t bytes() const { return bytes_; }
+  uint64_t bytes() const {
+    uint64_t bytes = 0;
+    for (int i = 0; i < Worker::kMaxWorkers; i++) {
+      bytes += worker_stats_[i].bytes;
+    }
+    return bytes;
+  }
 
   void set_track_bytes(bool track) { track_bytes_ = track; }
 
@@ -60,9 +78,13 @@ class Track final : public bess::GateHook {
 
  private:
   bool track_bytes_;
-  uint64_t cnt_;
-  uint64_t pkts_;
-  uint64_t bytes_;
+  struct alignas(64) TrackStats {
+    uint64_t cnt;
+    uint64_t pkts;
+    uint64_t bytes;
+  };
+
+  std::array<TrackStats, Worker::kMaxWorkers> worker_stats_;
 };
 
 #endif  // BESS_GATE_HOOKS_TRACK_