Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erlang remote calls aren't completed correctly in pipelines #475

Closed
scohen opened this issue Nov 7, 2023 · 0 comments · Fixed by #476
Closed

Erlang remote calls aren't completed correctly in pipelines #475

scohen opened this issue Nov 7, 2023 · 0 comments · Fixed by #476
Labels
bug Something isn't working completions Enhancements to Lexical's autocompleter
Milestone
0.4.1

Comments

@scohen
Copy link
Collaborator

scohen commented Nov 7, 2023 •
edited
Loading

They should have their first argument elided, but they don't.
for

"Hello" |> :binary.at|

the completion is at(subject, pos) but should be at(pos)
@scohen scohen added bug Something isn't working completions Enhancements to Lexical's autocompleter labels Nov 7, 2023
scohen added a commit that referenced this issue Nov 7, 2023
@scohen
Fix: Erlang function calls in pipes were incorrectly formatted
d51e81d 
Erlang remote calls were not being recognized as being in a pipeline
context because they're just atoms, and that wasn't included as a
valid token inside of pipelines. Thus, `in_context?(x, :pipe)` would
return false, and the first arguments to the functions would appear

Fixes #475
@scohen scohen mentioned this issue Nov 7, 2023
Merged
@scohen scohen added this to the 0.4.1 milestone Nov 7, 2023
scohen added a commit that referenced this issue Nov 8, 2023
@scohen
Fix: Erlang function calls in pipes were incorrectly formatted (#476)
92f1434 
Erlang remote calls were not being recognized as being in a pipeline
context because they're just atoms, and that wasn't included as a
valid token inside of pipelines. Thus, `in_context?(x, :pipe)` would
return false, and the first arguments to the functions would appear

Fixes #475
scohen added a commit that referenced this issue Nov 8, 2023
@scohen
Fix: Erlang function calls in pipes were incorrectly formatted (#476)
3989699 
Erlang remote calls were not being recognized as being in a pipeline
context because they're just atoms, and that wasn't included as a
valid token inside of pipelines. Thus, `in_context?(x, :pipe)` would
return false, and the first arguments to the functions would appear

Fixes #475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working completions Enhancements to Lexical's autocompleter
Projects
None yet
Milestone
0.4.1
Development

Successfully merging a pull request may close this issue.

Fix: Erlang function calls in pipes were incorrectly formatted lexical-lsp/lexical
1 participant
@scohen