Alias only returns modules #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change only suggests Modules, Behaviours and Protocols when completing items in an alias context. Prior, when you'd type `RootModule.|`, you'd get functions defined in `RootModule`. Now you'll only get submodules / behaviours / protocols, etc. I also noticed that the Environment behaviour was getting full of boolean functions, like: `pipe?`, and replaced that with `in_context?(env, <context_name>)`. In order to support aliases, I had to do some work in the environment and the tokenizer, which is much more reliable now.
scohen
force-pushed
the
alias-only-returns-modules
branch
from
b56919b to
4c881b8
Compare
scottming
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a two-commit PR. The first does what the title says, and the second fixes a bug in document.