Improved struct completion #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Struct completion under elixir sense was extremely inconsistent from context to context and even file to file. This was extremely frustrating, as structs might or might not complete depending, seemingly on the time of day. On the other hand, module completion was pretty consistent, so to fix the issue, prior to sending a document for completion, if we're in a struct reference, we strip it out to get the original module reference back. This means we'll only get module completions from elixir_sense, but we already check for struct references and if we detect that we're in one, turn module completions into struct completions. I've played around with this and it does seem to fix the problems I was having prior.
scottming
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Struct completion under elixir sense was extremely inconsistent from context to context and even file to file. This was extremely frustrating, as structs might or might not complete depending, seemingly on the time of day.
On the other hand, module completion was pretty consistent, so to fix the issue, prior to sending a document for completion, if we're in a struct reference, we strip it out to get the original module reference back. This means we'll only get module completions from elixir_sense, but we already check for struct references and if we detect that we're in one, turn module completions into struct completions.
I've played around with this and it does seem to fix the problems I was having prior.