Improve completions with default arguments #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scohen
force-pushed
the
improve_callable_completions
branch
2 times, most recently
from
514e02c to
6b94d2e
Compare
A couple of updates ago, elixir sense started returning the defaults of arguments along with the names of the arguments. This make our completions much worse, as the arity of the completion didn't match the arity of the function selected *and* the defaults would get pasted into the completion. This meant you had to remove the default from the completion, which was beyond annoying. These changes strip out defaults and ensure that the arity and arguments match the completion result generated by elixir sense.
scohen
force-pushed
the
improve_callable_completions
branch
from
6b94d2e to
28b639d
Compare
scottming
approved these changes
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of updates ago, elixir sense started returning the defaults of arguments along with the names of the arguments. This make our completions much worse, as the arity of the completion didn't match the arity of the function selected and the defaults would get pasted into the completion. This meant you had to remove the default from the completion, which was beyond annoying.
These changes strip out defaults and ensure that the arity and arguments match the completion result generated by elixir sense.