Boost callable completions that are not double underscore/default #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scohen
reviewed
May 31, 2023
apps/server/lib/lexical/server/code_intelligence/completion/translations/callable.ex
Outdated
Show resolved
Hide resolved
|
Hey @scohen, I've updated the code to use if instead of unless and also updated a test that was failing since now the completions will be boosted by default (maybe we also could boost to a lower level than 5) Also, do you think it makes sense to add any other functions to the |
scottming
reviewed
May 31, 2023
apps/server/lib/lexical/server/code_intelligence/completion/translations/callable.ex
Show resolved
Hide resolved
|
@viniciusmuller please write some tests, and I can't think of any functions that I'd de-boost right now other than the dunder ones. |
scohen
reviewed
Jun 1, 2023
apps/server/test/lexical/server/code_intelligence/completion/translations/function_test.exs
Outdated
Show resolved
Hide resolved
apps/server/test/lexical/server/code_intelligence/completion/translations/function_test.exs
Outdated
Show resolved
Hide resolved
apps/server/test/lexical/server/code_intelligence/completion/translations/function_test.exs
Outdated
Show resolved
Hide resolved
scohen
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowers the priority of double underscore or default functions when completing functions and captures.
Behavior with this patch:
Closes #183