Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue-178] Snippet translations for macro #208

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[issue-178] Snippet translations for macro #208

merged 1 commit into from
Jun 28, 2023

Conversation

Sleepful
Copy link
Collaborator

@Sleepful Sleepful commented Jun 7, 2023 •
edited
Loading

Open PR, should be ready for test macros

@Sleepful
Copy link
Collaborator Author

Sleepful commented Jun 15, 2023 •
edited
Loading

Todo:

  • Merge main and fix up boost: “Boosting now takes an item rather than the sort text, and has a different signature.”
  • Improve assert, assert_*...
  • Look through ExUnit for the others
    I will do those in another PR

@Sleepful Sleepful force-pushed the issue-178/enhance-snippets-for-test-macro branch 2 times, most recently from 2896270 to 42ba33e Compare June 22, 2023 07:09
@Sleepful Sleepful marked this pull request as ready for review June 23, 2023 06:20
@Sleepful Sleepful mentioned this pull request Jun 23, 2023
Closed
@Sleepful Sleepful requested review from scohen and scottming June 23, 2023 20:31
@Sleepful Sleepful force-pushed the issue-178/enhance-snippets-for-test-macro branch from b4f8157 to ea218a3 Compare June 24, 2023 02:28
@Sleepful
Copy link
Collaborator Author

@scohen ready :)
consolidated into a single commit

scohen
scohen approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@scohen scohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the one comment, then you're good.

apps/server/lib/lexical/server/code_intelligence/completion/translations/macro.ex Outdated Show resolved Hide resolved
@Sleepful Sleepful force-pushed the issue-178/enhance-snippets-for-test-macro branch from ea218a3 to b5e727a Compare June 28, 2023 22:15
@Sleepful Sleepful merged commit eb384c3 into main Jun 28, 2023
@Sleepful Sleepful deleted the issue-178/enhance-snippets-for-test-macro branch June 28, 2023 22:16
@scohen
Copy link
Collaborator

scohen commented Jul 6, 2023

Fixes #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scohen scohen scohen approved these changes

@scottming scottming Awaiting requested review from scottming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sleepful @scohen @scottming