Namespacing fixes / simplifications #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protocol and proto apps were not being namespaced because I missed appending a trailing '.' to the root module names, this meant both were being excluded. Circling back, I don't know why I was excluding any of the deps apps from namespacing, as it seems to work fine with it. It was also possisble to apply namespacing to modules that were already namespaced, so I added a check to ensure that doesn't happen. This was happening for plugins in external projects, as the plugin is a dep, but the code is written to the .lexical directory.
scohen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protocol and proto apps were not being namespaced because I missed appending a trailing '.' to the root module names, this meant both were being excluded.
Circling back, I don't know why I was excluding any of the deps apps from namespacing, as it seems to work fine with it.
It was also possisble to apply namespacing to modules that were already namespaced, so I added a check to ensure that doesn't happen. This was happening for plugins in external projects, as the plugin is a dep, but the code is written to the .lexical directory.