Fix extraneous logging in test #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blond11516
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
For what it's worth, Logger.configure doesn't use app env to update the level (and only that option) so this might be in indication that something special is going on with it.
On the other hand, the doc explicitly says config files should work, so... 🤷
|
I know, I'm very confused about this. |
I have no idea why logs are appearing with the compile-time config. I had to resort to calling Logger.configure() in test.exs. Something is up. Fixes #297
* Removed import from config.exs * Handled default case for ports exiting, which was causing a log message * Added lexical_test to plugin_runner's deps so we can run tests in its app directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is two commits, the first shuts up logging in test, but I don't understand why it's broken in the first place. More investigation is warranted.
The second cleans up the config files a bit and removes an unhandled message log message.