Position refactor #364
Merged
Position refactor #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachallaun
reviewed
Sep 12, 2023
apps/protocol/lib/lexical/protocol/convertibles/lexical.document.range.ex
Outdated
Show resolved
Hide resolved
apps/server/test/lexical/convertibles/lexical.plugin.diagnostic.result_test.exs
Outdated
Show resolved
Hide resolved
scohen
force-pushed
the
position-refactor
branch
from
bbad0d1 to
9fd75b0
Compare
This will help with conversions
In order to get tests passing, I wrote an assert_normalized macro that normalizes both sides of an assertion before calling assert. This prevents spurious failures when using PositionSupport and comparing different positions' line and valid? fields, since building these via PositionSupport won't set those fields properly
scohen
force-pushed
the
position-refactor
branch
from
67f7055 to
827808d
Compare
scohen
force-pushed
the
position-refactor
branch
from
18e997c to
bff02c6
Compare
scohen
force-pushed
the
position-refactor
branch
from
3e21ec0 to
a035cd5
Compare
zachallaun
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
I'm pretty confident in this. As you mentioned, there may be more we can do by looking further into errors.ex, but I think these changes are a good start and we're going to be building on them imminently, so there will be more opportunity to surface any weird behavior.
|
agreed, @zachallaun. I built this branch and have been using it as my main LSP for a couple days. No issues so far. |
scottming
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zachallaun and I realized that if you track the line that a position occurs on, you no longer need the document to do conversions. Watch this space.