Made aliases better handle the __aliases__ special form #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __aliases__ special form defines three types of aliases, and we were not handling one of them properly. This was made apparent to us in issue #378, where the module defined via `defmodule __MODULE__.Child` was not handled properly. This change fixes that issue, and should handle other aliases as well. Fixes #378
Moved module name calculation to Ast.Module.
scohen
force-pushed
the
fix-module-alias
branch
from
10ca31f to
cbcca8c
Compare
scottming
approved these changes
Sep 29, 2023
zachallaun
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aliases special form defines three types of aliases, and we were not handling one of them properly. This was made apparent to us in issue #378, where the module defined via
defmodule __MODULE__.Childwas not handled properly. This change fixes that issue, and should handle other aliases as well.Fixes #378