Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the eex compiled flaky test #394

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Conversation

scottming
Copy link
Collaborator

The previous CI was fine, and I rebased the latest branch, but the merge still fails the test

The previous CI was fine, and I rebased the latest branch, but the merge still fails the test
@scottming scottming marked this pull request as ready for review September 29, 2023 01:06
@scottming scottming requested a review from scohen September 29, 2023 01:12
Copy link
Collaborator

@zachallaun zachallaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make sense to me in a setup block unless these compiler options are being changed in individual tests.

I feel like this should be in a setup_all and we should be resetting whatever the previous compiler options were on exit, since this is shared global state:

setup_all do
  prev_compiler_options = Code.compiler_options()
  Code.compiler_options(parser_options: [columns: true, token_metadata: true])

  on_exit(fn ->
    Code.compiler_options(prev_compiler_options)
  end)

  :ok
end

@scottming scottming requested a review from scohen October 4, 2023 08:23
@scohen scohen merged commit eeaa74f into lexical-lsp:main Oct 4, 2023
@scottming scottming deleted the fix-flaky-tests branch December 20, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants