Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hash #505

Closed
wants to merge 1 commit into from
Closed

Update hash #505

wants to merge 1 commit into from

Conversation

tcoopman
Copy link

No description provided.

@scohen
Copy link
Collaborator

scohen commented Nov 30, 2023

@hauleth I thought this was automatic now.

@hauleth
Copy link
Contributor

hauleth commented Nov 30, 2023

Should be, but it seems that something did not work as expected. I will check. Testing GitHub Actions suck.

@scohen
Copy link
Collaborator

scohen commented Nov 30, 2023

it sure does. Anything I can do to help, @hauleth ?

@scohen
Copy link
Collaborator

scohen commented Dec 14, 2023

@hauleth any updates on this?

@wingyplus
Copy link
Contributor

From https://github.com/lexical-lsp/lexical/actions/runs/6898983605/job/18769850544#step:5:12, it seems we forgot to add some permission to allows github-bot to push to this repository.

@hauleth
Copy link
Contributor

hauleth commented Dec 25, 2023

Seems that would be a solution. Though IIRC that was working perfectly fine in my repos where I use something similar to handle CHANGELOG updates.

@scohen
Copy link
Collaborator

scohen commented Dec 28, 2023

giving a bot push permissions seems like a really bad thing, no?

@hauleth
Copy link
Contributor

hauleth commented Dec 28, 2023

I use it for automatic generation of CHANGELOG in some of my projects and find it acceptable solution. Though it is up to you if you.

@zachallaun
Copy link
Collaborator

@scohen Lots of projects use bots to push commits, many official Elixir repos included. I'm not concerned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants