Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up indexing by not calling deps_dir for every file #646

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

lukad
Copy link
Contributor

@lukad lukad commented Mar 12, 2024

This significantly speeds up indexing on very large codebases.
Brought down indexing time from ~2 hours to ~2 minutes on the project I tested this on.

@scohen
Copy link
Collaborator

scohen commented Mar 12, 2024

Well, the reason I made the deps_dir function was to do this, I was mistaken about how anonymous functions are built.
Mea culpa. Two hours is a heck of a run, heck, two minutes is a long indexing run.

How big is your codebase?

@scohen scohen merged commit c91f7a3 into lexical-lsp:main Mar 12, 2024
9 checks passed
@lukad
Copy link
Contributor Author

lukad commented Mar 12, 2024

15k+ elixir files, so it's no surprise that calling into the remote project for every file has such a big impact.
Anyways, thanks a lot for lexical. It makes working on such a large codebase so much more enjoyable.

@tessi
Copy link

tessi commented Mar 13, 2024

for the love of whatever deity you (not) believe in, thank you @lukad for this PR! And lexical in general for being awesome. This is saving my day on the very same humongous codebase 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants