Handled comments when resolving locations #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would resolve commented out code as if it wasn't commented out, which caused a crash in #638. Commented out code shouldn't resolve, but finding comments requires calling a different function with a different return shape than `Code.string_to_quoted`. This PR moves to `Code.string_to_quoted_with_comments` and puts the comment metadata into the analysis struct where it can be queried. Fixes #638
scohen
force-pushed
the
fix-entity-resolve-comments
branch
from
b2ff386 to
9bbef97
Compare
|
With this branch, I'm no longer getting errors on hover (#638), but I'm still receiving completions in comments: Still a worthwhile improvement to merge, as it addresses the major usability concern here. |
Moosieus
approved these changes
Mar 29, 2024
|
Interesting. I’m not getting completions like that. Is the comment thing not working? |
Refactored detectors to take analyses rather than documents, added detector csae for comments and added comment detection to code intelligence's completions
|
Answer: Because we explicitly enable completions for vscode regardless of everything else. I added an exemption for comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would resolve commented out code as if it wasn't commented out, which caused a crash in #638.
Commented out code shouldn't resolve, but finding comments requires calling a different function with a different return shape than
Code.string_to_quoted. This PR moves toCode.string_to_quoted_with_commentsand puts the comment metadata into the analysis struct where it can be queried.Fixes #638