Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added module attribute detection #679

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

scohen
Copy link
Collaborator

@scohen scohen commented Apr 2, 2024

Our environment can now detect when it's in a module attribute context

This will enable us to check for randomly named module attributes and fix some of our longstanding issues.

Our environment can now detect when it's in a module attribute context
@scohen scohen force-pushed the enhanced-module-attribute-detection branch from be318f1 to 026fe41 Compare April 2, 2024 20:36
@Moosieus
Copy link
Collaborator

Moosieus commented Apr 3, 2024

Should @callback and @macrocallback have their own context_types as well?

@scohen
Copy link
Collaborator Author

scohen commented Apr 3, 2024

@Moosieus pushed.

@scohen scohen requested review from Moosieus and scottming April 3, 2024 15:18
@scohen scohen merged commit 735e063 into main Apr 3, 2024
9 checks passed
@scohen scohen deleted the enhanced-module-attribute-detection branch April 3, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants