Included non-deps symbols in fuzzy matcher #704
Conversation
I noticed that the fuzzy matcher wouldn't match any unit tests. This is because their application is nil, as they're scripts. This change checks for nil applications, and if it finds one, only excludes the mapped entry if the path looks like it comes from a dependencies directory. Note, the deps directory name is hard coded. I originally queried the project for the deps directory name, but this would include dependencies in the projects directory, which was quite annoying, hence the hard-coding.
Dependencies are now detected via seeing if the path is in our deps directory or one of our sub-project's dependencies.
|
@zachallaun please take another look. |
|
FYI, @zachallaun the previous approach wouldn't allow searches for |
There was a problem hiding this comment.
Made a couple suggestions.
I do think this is a better approach than the previous iteration. One downside is that it finds the existing deps directories once when fuzzy is initialized, which means that any directories added later (from project restructuring/etc. maybe?) won't be ignored.
There's really no way to fix this. There is a lot of trouble with LSP file watching, several editors (emacs included) simply don't deliver |
Co-authored-by: Zach Allaun <[email protected]>
scohen
force-pushed
the
include-app-unit-tests
branch
from
1a3b623 to
1a9f403
Compare
I noticed that the fuzzy matcher wouldn't match any unit tests. This is because their application is nil, as they're scripts. This change checks for nil applications, and if it finds one, only excludes the mapped entry if the path looks like it comes from a dependencies directory.
Note, the deps directory name is hard coded. I originally queried the project for the deps directory name, but this would include dependencies in the projects directory, which was quite annoying, hence the hard-coding.