Fallback to ElixirSense when unable to find any definitions with Indexer
#707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scohen
reviewed
Apr 19, 2024
apps/remote_control/lib/lexical/remote_control/code_intelligence/definition.ex
Outdated
Show resolved
Hide resolved
scohen
approved these changes
Apr 19, 2024
scohen
reviewed
Apr 19, 2024
apps/remote_control/lib/lexical/remote_control/code_intelligence/definition.ex
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But I don't know how to test this fallback more extensively, because
Patchalso cannot patch a call to a function within a project node, and I also don't want to introduce a dependency on ecto for navigation project.