Stopped passing the server project over to remote_control #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemoteControl has a global project object that's been augmented with extra information, but sometimes we pass server's project over to remote control. The server doesn't have this extra information, and in cases of compilation, it can cause spurious failures, like not being able to find a project's `.formatter.exs` Fixes #727
|
@soundmonster this is a much simpler change that should also fix your issue. |
soundmonster
approved these changes
May 7, 2024
zachallaun
approved these changes
May 7, 2024
There was a problem hiding this comment.
This looks good to me.
Something that comes to mind that would be a little more verbose in places but would ensure that the correct project is always used in remote control: RemoteControl.call(project, m, :f, [...]) could always pass the project as the first argument, so the actual call would end up being m.f(RemoteControl.get_project(), ...). Some functions would have to ignore this argument, but it would be a stronger guarantee that functionality added in the future uses the right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoteControl has a global project object that's been augmented with extra information, but sometimes we pass server's project over to remote control. The server doesn't have this extra information, and in cases of compilation, it can cause spurious failures, like not being able to find a project's
.formatter.exsFixes #727