Added safe_split to Ast.Module #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When lexical deals with modules, they can either be erlang or elixir modules. However, Module.split will raise an exception when called on an erlang module. We've implemented safe_split in a couple of places, and this centralizes the base logic. Safe split will return the type of module, and if it's an erlang or elixir module. It also allows the module's components to be either in bianry or atom form.
scottming
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When lexical deals with modules, they can either be erlang or elixir modules. However, Module.split will raise an exception when called on an erlang module. We've implemented safe_split in a couple of places, and this centralizes the base logic.
Safe split will return the type of module, and if it's an erlang or elixir module. It also allows the module's components to be either in bianry or atom form.