Elixir 1.17 #760

scohen · 2024-05-30T18:30:19Z

Changed single quoted charlists to use the ~c sigil

zachallaun · 2024-06-01T13:00:52Z

I see some errors from ElixirSense. If ElixirSense is using :elixir_tokenizer, we may not be able to complete this upgrade unless we update to the latest version of ElixirSense. I believe this commit changed the return value of :elixir_tokenizer.tokenize/4 to both return an extra value in the :ok tuple (rev_terminators) and to return tokens in reverse order. (Edit: I actually don't think token order changed, just the extra item in the tuple.)

zachallaun · 2024-06-01T13:01:52Z

Yep, here's the commit in elixir_sense that adds support for the 1.17 tokenizer: elixir-lsp/elixir_sense@a41777a

kirillrogovoy · 2024-06-13T15:12:00Z

Just wanted to say that, except for all the deprecation warnings, the latest main version (as of right now) of Lexical runs well on 1.17.0

I had to locally "allow" it though through editing boot.ex.

Maybe allow it for everyone today? Or is it actually buggy and I'm failing to see it?

scohen · 2024-06-13T20:48:48Z

@kirillrogovoy are you using this branch?

apps/server/lib/lexical/server/boot.ex

kirillrogovoy · 2024-06-14T07:38:11Z

@scohen I was referring to the latest main where I locally added "1.17.0" => ">= 1.17.0" to boot.ex (not -rc anymore)

Haven't tried using this branch. My point was that, since 1.17.0 release is out now, a bunch of people are upgrading their setup (e.g. I now run 1.17.0 both locally and in production), and Lexical refuses to start due to that version check although technically it works well if you bypass the check. Or at least if feels like it to me.

So my suggestion was that maybe we could add that "1.17.0" => ">= 1.17.0" line to main already while fixing the compiler warnings here in this branch. Otherwise, many people might get caught off guard with no straightforward remedy. At, least, this way they can just git pull, start the LSP, and continue on with their work.

scohen · 2024-06-14T18:43:02Z

The problem getting those changes merged is that we have a bunch of test failures under 1.17 that need to be addressed before we merge. They look legitimate to me, and will affect how errors are shown in the UI.

miguno · 2024-06-14T21:40:50Z

I, too, am looking forward to Elixir 1.17 support. Thanks in advance for making it happen, even if it should take some time. Your work on lexical is much appreciated!

Changed single quoted charlists to use the ~c sigil

scottming · 2024-06-27T02:09:23Z

@miguno @kirillrogovoy @bigardone I have fixed all the test errors for the 5 versions. Please pull the latest code from this branch and test it when you have a chance. If there are no further issues, we will merge it ASAP after the review.

cc @scohen @zachallaun @Moosieus

kirillrogovoy · 2024-06-27T07:33:25Z

Thanks a lot @scottming!

I've just pulled, checked out the branch, and ran mix deps.get, mix package.

As far as I can tell, Lexical has compiled successfully, and all basic LSP functions work in my Neovim.

Will post any issues here.

bigardone · 2024-06-27T07:39:30Z

👋🏼 @scottming, thanks for the update! Same as @kirillrogovoy here. I just pulled the branch, and everything seems to be working fine. 🙌🏼

Elixir 1.17's AST includes `end_of_expression`, which allows `Sourceror` to return a more precise range. Therefore, we no longer need to add 2 in `insert_position`.

…o_quoted_with_comments/2` And Copied the latest future erlang code

Because the latest `tokenize` is more accurate, some of our previous tests were written incorrectly, but they still passed at that time.

@type

In situations like this, ` @type a|`, the column of surround_context should not be 7 (` @type| a`), but rather 8 (` @type |a`). Therefore, we should not subtract 1."

…column is at the maximum value of end

Sourceror has already fixed the errors related to anonymous functions, so we no longer need to handle such functions specially.

In version 1.17, the position of the error returned for incomplete symbols like `%{` is placed before the `%`.

Update all of `elixir_interpolation` call to `future_elixir_interpolation`

…s_set_theoretic_types?`

scohen requested review from zachallaun, scottming and Moosieus May 30, 2024 18:30

bigardone reviewed Jun 14, 2024

View reviewed changes

apps/server/lib/lexical/server/boot.ex Outdated Show resolved Hide resolved

scohen and others added 6 commits June 26, 2024 09:03

Elixir 1.17

6b41d58

Changed single quoted charlists to use the ~c sigil

Added elixir 1.17 / erlang 27 to build matrix

6dae945

added 1.17 and erlang 27 to boot script

a219b9b

Upgraded elixir sense

f7171f7

Added 1.17.0 to support matrix

41e7497

Upgrade sourceror from 1.0.3 to 1.4

45bb865

scottming force-pushed the elixir-1-17 branch 6 times, most recently from 318a7dd to 3a2e44c Compare June 27, 2024 00:05

scottming force-pushed the elixir-1-17 branch from 4d5f5da to f0f7901 Compare June 28, 2024 08:29

scottming added 3 commits June 28, 2024 16:45

Fix the issue with the position of insert_position.

cdf93e5

Elixir 1.17's AST includes `end_of_expression`, which allows `Sourceror` to return a more precise range. Therefore, we no longer need to add 2 in `insert_position`.

Use :future_elixir instead of :elixir when calling `Code.string_t…

8598871

…o_quoted_with_comments/2` And Copied the latest future erlang code

Fix Detection tests

462c1bb

Because the latest `tokenize` is more accurate, some of our previous tests were written incorrectly, but they still passed at that time.

scottming added 6 commits June 28, 2024 16:53

Upgrade Elixir Future.Code modules

dd222d6

Fix the has_surround_context? bug when the cursor_context is var

0431ae9

In situations like this, ` @type a|`, the column of surround_context should not be 7 (` @type| a`), but rather 8 (` @type |a`). Therefore, we should not subtract 1."

Fix the issue where surround_context fails to fetch results when the …

9b4966a

…column is at the maximum value of end

Fix metadata tests and implementations

9d50aa3

Sourceror has already fixed the errors related to anonymous functions, so we no longer need to handle such functions specially.

Fix 1.17 parse error issue

ddd9ba1

In version 1.17, the position of the error returned for incomplete symbols like `%{` is placed before the `%`.

Fix tokenize error for the elixir version below or euqal 1.15

952685f

Update all of `elixir_interpolation` call to `future_elixir_interpolation`

scottming force-pushed the elixir-1-17 branch from af0405a to 952685f Compare June 28, 2024 08:54

mix format and upgrade rename the 1.17 determine function to `contain…

1c41eb3

…s_set_theoretic_types?`

Moosieus approved these changes Jul 3, 2024

View reviewed changes

Moosieus merged commit ef171d2 into main Jul 3, 2024
12 checks passed

dvic mentioned this pull request Jul 8, 2024

Crash with OTP 27.0 #788

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Elixir 1.17 #760

Elixir 1.17 #760

scohen commented May 30, 2024

zachallaun commented Jun 1, 2024 •

edited

Loading

zachallaun commented Jun 1, 2024

kirillrogovoy commented Jun 13, 2024

scohen commented Jun 13, 2024

kirillrogovoy commented Jun 14, 2024

scohen commented Jun 14, 2024

miguno commented Jun 14, 2024

scottming commented Jun 27, 2024 •

edited

Loading

kirillrogovoy commented Jun 27, 2024 •

edited

Loading

bigardone commented Jun 27, 2024

Elixir 1.17 #760

Elixir 1.17 #760

Conversation

scohen commented May 30, 2024

zachallaun commented Jun 1, 2024 • edited Loading

zachallaun commented Jun 1, 2024

kirillrogovoy commented Jun 13, 2024

scohen commented Jun 13, 2024

kirillrogovoy commented Jun 14, 2024

scohen commented Jun 14, 2024

miguno commented Jun 14, 2024

scottming commented Jun 27, 2024 • edited Loading

kirillrogovoy commented Jun 27, 2024 • edited Loading

bigardone commented Jun 27, 2024

zachallaun commented Jun 1, 2024 •

edited

Loading

scottming commented Jun 27, 2024 •

edited

Loading

kirillrogovoy commented Jun 27, 2024 •

edited

Loading