Simplifications in remote_control
#778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachallaun
force-pushed
the
za-simplify-remote-control-app
branch
from
0d379a4 to
99d9b0f
Compare
scohen
reviewed
Jul 10, 2024
|
Left one comment, otherwise it looks good. |
scohen
approved these changes
Jul 10, 2024
We don't support Elixir < 1.11, so the feature check is unnecessary.
zachallaun
force-pushed
the
za-simplify-remote-control-app
branch
from
99d9b0f to
466119b
Compare
`ModuleMappings.update/2` was only used in the tests. I've refactored them to use dispatched messages, which is how the mappings are actually updated during regular use.
It was only used for two calls and was difficult to understand. Instead, we now explicitly pass an mfa tuple to `RemoteControl.Modules.with_prefix/2` and the module being testing is added as the first arg.
zachallaun
force-pushed
the
za-simplify-remote-control-app
branch
from
466119b to
60c8701
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits are atomic and can be reviewed individually.