Guard against new positions with line or char less than 1

apps/common/lib/lexical/ast.ex

@@ -618,7 +618,7 @@ defmodule Lexical.Ast do
 
   defp one_line_range(%Document{} = document, line_number) do
     start_pos = Position.new(document, line_number, 1)
-    end_pos = Position.new(document, line_number + 1, 0)
+    end_pos = Position.new(document, line_number + 1, 1)
     Range.new(start_pos, end_pos)
   end
 

apps/remote_control/lib/lexical/remote_control/code_action/handlers/replace_remote_function.ex

@@ -54,7 +54,7 @@ defmodule Lexical.RemoteControl.CodeAction.Handlers.ReplaceRemoteFunction do
   defp apply_transform(%Document{} = doc, line_number, module, function, suggestion) do
     {:ok, doc, analysis} = Document.Store.fetch(doc.uri, :analysis)
     function_atom = String.to_atom(function)
-    position = Document.Position.new(doc, line_number, 0)
+    position = Document.Position.new(doc, line_number, 1)
 
     doc
     |> Ast.traverse_line(line_number, [], fn

apps/remote_control/lib/lexical/remote_control/search/indexer/source/reducer.ex

@@ -32,7 +32,7 @@ defmodule Lexical.RemoteControl.Search.Indexer.Source.Reducer do
       blocks: [Block.root()],
       entries: [],
       extractors: extractors || @extractors,
-      position: {0, 0}
+      position: {1, 1}
     }
   end
 

apps/remote_control/test/lexical/remote_control/code_action/handlers/replace_remote_function_test.exs

@@ -35,8 +35,8 @@ defmodule Lexical.RemoteControl.CodeAction.Handlers.ReplaceRemoteFunctionTest do
 
     range =
       Document.Range.new(
-        Document.Position.new(document, line_number, 0),
-        Document.Position.new(document, line_number + 1, 0)
+        Document.Position.new(document, line_number, 1),
+        Document.Position.new(document, line_number + 1, 1)
       )
 
     diagnostic = Diagnostic.new(range, message, nil)

apps/remote_control/test/lexical/remote_control/code_action/handlers/replace_with_underscore_test.exs

@@ -19,8 +19,8 @@ defmodule Lexical.RemoteControl.CodeAction.Handlers.ReplaceWithUnderscoreTest do
 
     range =
       Document.Range.new(
-        Document.Position.new(document, line_number, 0),
-        Document.Position.new(document, line_number + 1, 0)
+        Document.Position.new(document, line_number, 1),
+        Document.Position.new(document, line_number + 1, 1)
       )
 
     diagnostic = Diagnostic.new(range, message, nil)

apps/server/lib/lexical/server/code_intelligence/completion/translations/callback.ex

@@ -65,7 +65,7 @@ defmodule Lexical.Server.CodeIntelligence.Completion.Translations.Callback do
       start_char =
         case String.split(line, "def", parts: 2) do
           [i, _] -> String.length(i) + 1
-          [_] -> 0
+          [_] -> 1
         end
 
       end_char = String.length(line) + 1

projects/lexical_shared/lib/lexical/document/position.ex

@@ -41,12 +41,12 @@ defmodule Lexical.Document.Position do
 
   @spec new(line_container(), line(), character()) :: t
   def new(%Document{} = document, line, character)
-      when is_number(line) and is_number(character) do
+      when is_number(line) and is_number(character) and line >= 1 and character >= 1 do
     new(document.lines, line, character)
   end
 
   def new(%Document.Lines{} = lines, line, character)
-      when is_number(line) and is_number(character) do
+      when is_number(line) and is_number(character) and line >= 1 and character >= 1 do
     line_count = Document.Lines.size(lines)
     starting_index = lines.starting_index