Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show syntax macro completions when Kernel. is prefixed to the cursor. #840

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Moosieus
Copy link
Collaborator

Closes #832.

This solution is imperfect because it requires the prefix to end exactly with Kernel.

However it works in most cases because:

  • Completions are usually requested at the point of Kernel.|
  • Completions are cached by clients for the next few characters.

In the exceptional rare case where a user copy/pastes something like Kernel.=| and requests a completion, these won't show. Not a perfectly correct solution, but our handling of syntax macros is already a matter of taste, so ¯\_(ツ)_/¯

@Moosieus Moosieus requested a review from scohen November 20, 2024 03:44
@Moosieus Moosieus merged commit bc36cc4 into main Nov 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP is not suggesting some Kernel operators
2 participants