Fixed Length OID Processing Fixes #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some PEP 8 changes in etingof#243, the temporary variable name clashed with the name of the OID being processed. This change renames the temporary variable to fix this clash.
After the following commit, lextudio@4c71d45, the fixed length accessor functions for the Octet String class were changed to be PEP 8 compliant. This commit updates SNMPv2-SMI to use the PEP 8 compliant function calls.
|
|
|
I feel obliged to remark here that while your changes are an excellent improvement as far as I can tell, last week's commit 755e8a7 once again renamed the underlying attribute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the long wait on this, I have been super busy and didn't manage to get around to this.
For context: This fixes the closed issue #141 that is still present in the main branch after some initial testing.
The following pull request restores the Fixed Length OID processing functionality that began to cause crashes for fixed length OID strings after PEP 8 changes were applied. Additionally, this updates the SNMPv2-SMI.py file to use the newer PEP 8 compliant function names.