Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference EVE API from the new lf-edge/eve-api repo #121

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

milan-zededa
Copy link
Contributor

This also updates EVE API to the latest commit.

This also updates EVE API to the latest commit.

Signed-off-by: Milan Lenco <[email protected]>
@@ -10,7 +10,7 @@ require (
github.com/google/go-tpm v0.3.3
github.com/gorilla/mux v1.7.2
github.com/kr/text v0.2.0 // indirect
github.com/lf-edge/eve/api/go v0.0.0-20230612203304-13fba79dd3af
github.com/lf-edge/eve-api/go v0.0.0-20231214160111-99ce4e43be4b
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any plans for tagged version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of any plans for tagging, maybe @uncleDecart has some plans for eve-api versioning?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no knowledge of explicit plans for it. We probably should. Part of the reason for moving the api out of eve repo was to let it have its own pace of change and CI, and not be bound to the much larger and slower (which it has to be) EVE CI, part was because the dependency tree is much cleaner (api upstream of both adam and eve and eden independently), but part was so that it could stand alone, be versioned, independent source of truth, etc.

Either way, we should get this in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milan-zededa, there will be later :)

Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this.

@deitch deitch merged commit 9f6fca2 into lf-edge:master Dec 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants