Improve release process #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncleDecart
requested review from
deitch,
milan-zededa,
shjala and
yash-zededa
deitch
requested changes
Nov 25, 2024
In case somebody wants to pull adam from ghcr.io for whatever reason, they will have the opportunity to do so Signed-off-by: Pavel Abramov <[email protected]>
It is easier to read the doc rather than jump around github actions Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
force-pushed
the
improve-release
branch
from
8c1dd79 to
aff50a7
Compare
|
gotta rebase... |
uncleDecart
force-pushed
the
improve-release
branch
from
aff50a7 to
33e96c1
Compare
deitch
approved these changes
Nov 26, 2024
|
LGTM. Ready to merge? |
|
Yes, let's merge and then draft a release for v0.1.0 as a starting point |
yash-zededa
approved these changes
Nov 27, 2024
|
LGTM. |
|
Okay, may the force be with us then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is RFC. It introduces doc, describing release process and changes to gha to publish release to ghcr.io as well as to dockerhub. The process described in the doc is similar to what we are doing in Eden and EVE, that way we can be consistent across repos