Forcing EVE to use V1 API while #16 is getting fixed #17
Conversation
Signed-off-by: Roman Shaposhnik <[email protected]>
There was a problem hiding this comment.
I get what you are trying to do, but I don't think this goes in adam itself, or at least not yet. Let's keep all of the "embedded" stuff in the eve-embedded.sh script, and we can look at a single change that puts all of it in a separate command or option in adam after
| } | ||
|
|
||
| // FIXME: this is going away as part of fixing https://github.com/lf-edge/adam/issues/16 | ||
| err = ioutil.WriteFile(path.Join(configDir, "Force-API-V1"), []byte{}, 0644) |
There was a problem hiding this comment.
Should these not go into eve-embedded.sh rather than here? This /config/Force-API-V1 file is only in the embedded context, and only makes sense to eve itself.
I don't object to adding some capabilities to adam itself, so that we can eventually get rid of eve-embedded.sh (I was thinking about it, actually), but let's not put them in in an unstructured way. This whole thing can be done in a single cp command and a single echo command in eve-embedded.sh
There was a problem hiding this comment.
No it actually has to go everywhere -- not just into embedded. Otherwise there's absolutely no way for us to signal to the user that this needs to be somehow handed over to EVE via its config.
In fact, that the whole point of Adam generating an EVE config -- it needs to have a way to signal of what options need to be there for it to actually function.
Hence I think it actually belongs here -- the only other alternative @deitch is to completely drop this EVE configuration generation -- 'cuz it really has to be complete or it needs to be dropped.
The thing we don't want it to be is misleading -- that's the worst option of all.
There was a problem hiding this comment.
Adam already was writing out an eve-compatible config to a local directory when run in adam server mode. Right. In that case, this makes sense.
Well, but the problem is -- its not just embedded. Eden folks ran into issue here as well. Like I said -- we need to make sure that Adam either generates all config knobs that need to be given to EVE for it to actually function. OR We need to completely drop EVE config generation from Adam. For now -- I'd prefer option #1 |
This also simplifies the handshake between EVE and Adam (especially for the embedded case)