Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default remote loglevel #1044

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

europaul
Copy link
Contributor

@europaul europaul commented Dec 1, 2024

This PR is preparing Eden tests to work with the re-enabled remote log level config parameter that's coming in lf-edge/eve#4413.

@europaul europaul requested a review from uncleDecart as a code owner December 1, 2024 20:52
For Eden tests it's easier to check the logs sent to the controller
than to check the logs on the EVE. This change sets the default
remote log level to the same value as the default log level to make
all logs produced on the device also available on the controller.

Signed-off-by: Paul Gaiduk <[email protected]>
Since the test is looking for a log message that's generated at level
info we need to make sure that we set the log levels of the producing
agent to info as well. After the test the original settings are restored.

Signed-off-by: Paul Gaiduk <[email protected]>
@europaul europaul force-pushed the change-default-remote-loglevel branch from 2a6141b to d4ca35e Compare December 1, 2024 20:58
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uncleDecart
Copy link
Member

uncleDecart commented Dec 2, 2024

I'll merge the thing and will release new eden in a bit, once I'll add GHA Workflow to run neoeden alongside with other tests (currently just sec test)

Edit: as per comment here

Copy link
Member

@uncleDecart uncleDecart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uncleDecart uncleDecart merged commit 9b0d3c9 into lf-edge:master Dec 2, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants