Fix unknown issue with eve agent init #3567
Conversation
christoph-zededa
requested review from
rene,
rouming,
milan-zededa,
zedi-pramodh and
eriknordmark
as code owners
This reverts commit 8b66837. Signed-off-by: Christoph Ostarek <[email protected]>
This reverts commit 8b1f5ba. Signed-off-by: Christoph Ostarek <[email protected]>
christoph-zededa
force-pushed
the
fix_ztests
branch
from
6f4cb38 to
c7c98de
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3567 +/- ##
==========================================
- Coverage 19.47% 19.46% -0.01%
==========================================
Files 231 231
Lines 50220 50211 -9
==========================================
- Hits 9778 9776 -2
+ Misses 39723 39719 -4
+ Partials 719 716 -3
☔ View full report in Codecov by Sentry. |
| @@ -81,7 +82,7 @@ func Run(ps *pubsub.PubSub, loggerArg *logrus.Logger, logArg *base.LogObject, ar | |||
| } | |||
| log.Functionf("processed Vault Status") | |||
|
|
|||
| currentHypervisor := hypervisor.CurrentHypervisor() | |||
| currentHypervisor := domainmgr.CurrentHypervisor() | |||
There was a problem hiding this comment.
It probably makes sense to have this pick up and use the boot time hypervisor by parsing /run/eve-hv-type.
There was a problem hiding this comment.
But let's do that in a separate PR.
There was a problem hiding this comment.
Looks like this fixes the problem but it would be good to update the title and description (you fixed EVE not ztests). The issue was failing to update EVE-OS from the latest master to something else, but did you figure out why that init function caused things to break?
christoph-zededa
changed the title
Internal tests showed a problem with a machine not coming up again if these commits are included; for now reverting them.