[12.0-stable] pillar/assignableadapters: clear error strings #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhmSpectator
approved these changes
Sep 11, 2024
|
lol, why does Yetus scream only here... |
christoph-zededa
force-pushed
the
12.0-stable_clear_err_on_usb_collision
branch
2 times, most recently
from
60dbfb6 to
93381b6
Compare
|
@christoph-zededa don't we have to port it into 11.0-stable? |
I don't see the affected code in |
|
@christoph-zededa can we close this PR for now, if you want to replace it with a new one? |
I will use this PR, but now it is in draft. |
christoph-zededa
force-pushed
the
12.0-stable_clear_err_on_usb_collision
branch
from
50e1918 to
d91b31c
Compare
github-actions
bot
requested review from
jsfakian,
milan-zededa,
OhmSpectator,
rouming and
uncleDecart
for usb collisions: 1. create two usb adapters with collision 2. change the usbaddr of one of the adapters now the collision should be gone, but as the error string for both adapters has been set, it was not cleared for parentassigngrp cycles: 1. create two usb adapters that have each other as parentassigngrp 2. change the parentassignrp of one of the adapters now the cycle should be gone, but as the error string for both adapters has been set, it was not cleared Also don't overwrite errors and be able to clear specific error types Signed-off-by: Christoph Ostarek <[email protected]> (cherry picked from commit d1e13b8)
christoph-zededa
force-pushed
the
12.0-stable_clear_err_on_usb_collision
branch
from
d91b31c to
1b8e10d
Compare
done |
OhmSpectator
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now the collision should be gone, but
as the error string for both adapters has been set, it was not cleared