pillar/hypervisor: fix discrepancy in setupSpec #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-zededa
requested review from
OhmSpectator,
rene and
rouming
as code owners
|
Required to be backported (so labeled with "stable" or/and labeled with "fix")? |
rouming
reviewed
Sep 23, 2024
| } | ||
| } | ||
|
|
||
| // I/O Adapter device access |
rene
reviewed
Sep 23, 2024
|
@christoph-zededa could you describe what was the issue observed with the current master? |
christoph-zededa
force-pushed
the
fix_setup_spec
branch
from
211b6a0 to
0556d33
Compare
|
Please rebase on the latest master. There were changes in the code close to changed here. I wanna be sure all together it's fine. |
kvm and xen sent an empty list of ioBundles to setupSpec, so that it failed to lookup devices with `aa.LookupIoBundleAny(adapter.Name)` turns out, we can just not call this piece of code in the case of kvm and xen - only when using it directly from containerd; then we also include the proper ioBundles Signed-off-by: Christoph Ostarek <[email protected]>
christoph-zededa
force-pushed
the
fix_setup_spec
branch
from
0556d33 to
3e46d3b
Compare
|
I also moved it into |
53d3ee8 is in no stable branch yet, so no need to backport it. |
OhmSpectator
approved these changes
Sep 23, 2024
eriknordmark
added
stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kvm and xen sent an empty list of ioBundles to setupSpec, so that it failed to lookup devices with
aa.LookupIoBundleAny(adapter.Name)turns out, we can just not call this piece of code in the case of kvm and xen - only when using it directly from containerd; then we also include the proper ioBundles