GitHub Actions: Switch to GitHub-hosted runners #4280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest documentation on GitHub shows that their runners have same resources as BuildJet. Why not use free stuff? Signed-off-by: Pavel Abramov <[email protected]>
| @@ -23,9 +23,9 @@ jobs: | |||
| include: | |||
| - os: buildjet-4vcpu-ubuntu-2204-arm | |||
| arch: arm64 | |||
| - os: buildjet-4vcpu-ubuntu-2004 | |||
| - os: ubuntu-20.04 | |||
There was a problem hiding this comment.
But here you switch from buildjet to a regular one?
There was a problem hiding this comment.
So in this particular case it won't be that easy, because we're running matrix and we have runs-on parameter, and we have both amd64 and arm arch to avoid cross-compiling. We can add a second option as fallback in runs-on parameter, but it'll mess up arm runner. I think it makes sense to switch to GH-hosted runners here, since it'll free up buildjet runners a bit
OhmSpectator
approved these changes
Sep 23, 2024
|
Are we ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest documentation on GitHub shows that their
runners have same resources as BuildJet. Why not
use free stuff?
https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories