Allow EVE memory limits above 4GB. #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhmSpectator
added
bug
Previously, EVE's memory limit was stored in bytes using a uint32 value in the global configuration, limiting the maximum memory to approximately 4GB. This restriction prevented setting higher memory limits necessary for applications like kubevirt. This commit introduces support for specifying the EVE memory limit in mebibytes (MiB) while maintaining backward compatibility with the byte-based configuration. If the byte-based limit is set and valid, it is used; otherwise, the MiB-based limit is applied. This enhancement allows EVE to support memory limits beyond 4GB and ensures accurate memory management, preventing issues in scenarios that require higher memory allocations. Signed-off-by: Nikolay Martyanov <[email protected]>
OhmSpectator
force-pushed
the
fix/allow-higher-eve-mem-limits
branch
from
b6753fd to
c43ab97
Compare
eriknordmark
approved these changes
Sep 30, 2024
|
The pull limits, again =( |
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, EVE's memory limit was stored in bytes using a uint32 value in the global configuration, limiting the maximum memory to approximately 4GB. This restriction prevented setting higher memory limits necessary for example for kubevirt. Configuring a memory limit larger than 4GB caused EVE to incorrectly store the value as 0, resulting in inaccurate memory requirement estimations.
This commit changes the memory limit configuration to use mebibytes (MiB) instead of bytes, allowing EVE to support memory limits beyond 4GB.