[13.4-stable] Set WType even for wireless ports without network config #4369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nim, zedrouter and other microservices depend on the WType port attribute to recognize wireless network port. This is needed even in cases where the wireless adapter is not really used and has no network config attached. Otherwise, we may get to situation where we try to bridge a wireless adapter or perform some other invalid operation, especially after the switch NI enhancements done in: 7a6981b In the case wireless config is not present, we can get the physical port type from the device model and set WType accordingly. Signed-off-by: Milan Lenco <[email protected]> (cherry picked from commit 610b4ac)
milan-zededa
requested review from
OhmSpectator,
rouming and
eriknordmark
as code owners
|
Our GH Actions do not like when the source branch has the same name as the target branch, I guess =( |
OhmSpectator
approved these changes
Oct 17, 2024
Correct |
That's correct @OhmSpectator , I've seen these kind of errors before.... |
@yash-zededa do you think we can quickly fix it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nim, zedrouter and other microservices depend on the WType port attribute to recognize wireless network port. This is needed even in cases where the wireless adapter is not really used and has no network config attached. Otherwise, we may get to situation where we try to bridge a wireless adapter or perform some other invalid operation, especially after the switch NI enhancements done in: 7a6981b
In the case wireless config is not present, we can get the physical port type from the device model and set WType accordingly.
Signed-off-by: Milan Lenco [email protected]
(cherry picked from commit 610b4ac)