memory-monitor: Fix memory monitor config update for debug container. #4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the pkill command in the memory-monitor-update-config case to use the process name (memory-monitor) instead of the full path (/sbin/memory-monitor). This change ensures compatibility with the debug container, which uses procps-ng version 3.3.17 that does not support full paths in the pkill command. This adjustment makes the command functional when executed in the debug container, improving usability for users connecting via SSH. Signed-off-by: Nikolay Martyanov <[email protected]>
christoph-zededa
approved these changes
Dec 2, 2024
OhmSpectator
added
bug
milan-zededa
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the pkill command in the memory-monitor-update-config case to use the process name (memory-monitor) instead of the full path (/sbin/memory-monitor). This change ensures compatibility with the debug container, which uses procps-ng version 3.3.17 that does not support full paths in the pkill command.
This adjustment makes the command functional when executed in the debug container, improving usability for users connecting via SSH.
To be backported into 13.4.0-stable