Allow download retrying if the computed and configured checksums differ. #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsfakian
commented
Dec 3, 2024
jsfakian
commented
- We have identified that downloading images under poor networking conditions from datastores might fail silently due to the SDK libraries we use for for Azure and AWS. This happens when we are installing new applications.
- Another observation we made is that when we manually try re-installing the applications, they eventually succeed in the installation.
- With this patch, we automate retrying the image download a fixed number of times (5 by default) if the computed versus the configure checksums differ.
jsfakian
requested review from
OhmSpectator,
deitch,
rouming,
milan-zededa and
eriknordmark
as code owners
jsfakian
force-pushed
the
BUG-CI349-checksum-mismatch
branch
from
dbcf812 to
c8cf95f
Compare
OhmSpectator
reviewed
Dec 3, 2024
jsfakian
force-pushed
the
BUG-CI349-checksum-mismatch
branch
from
c8cf95f to
213e610
Compare
eriknordmark
reviewed
Dec 3, 2024
eriknordmark
reviewed
Dec 3, 2024
OhmSpectator
reviewed
Dec 4, 2024
| if config.RefCount != 0 && (status.HasError() || status.State != types.DOWNLOADED) { | ||
| // or status is not downloaded or retry then do install | ||
| if config.RefCount != 0 && (status.HasError() || | ||
| status.State != types.DOWNLOADED || config.DoRetry) { |
There was a problem hiding this comment.
The State != types.DOWNLOADED condition looks suspicious to me. Isn't it too vague? Shouldn't it be at least status.State < types.DOWNLOADED && ... or even status.State == DOWNLOADING && ... ?
There was a problem hiding this comment.
It was like that before. Should we change it?
eriknordmark
reviewed
Dec 6, 2024
rene
reviewed
Dec 10, 2024
jsfakian
force-pushed
the
BUG-CI349-checksum-mismatch
branch
from
213e610 to
9884a04
Compare
jsfakian
force-pushed
the
BUG-CI349-checksum-mismatch
branch
from
9884a04 to
9110498
Compare
jsfakian
force-pushed
the
BUG-CI349-checksum-mismatch
branch
from
9110498 to
619ad71
Compare
jsfakian
force-pushed
the
BUG-CI349-checksum-mismatch
branch
from
619ad71 to
9d1f5ae
Compare
- We have identified that downloading images under poor networking conditions from datastores might fail silently due to the SDK libraries we use for for Azure and AWS. This happens when we are installing new applications. - Another observation we made is that when we manually try re-installing the applications, they eventually succeed in the installation. - With this patch, we automate retrying the image download a fixed number of times (5 by default) if the computed versus the configure checksums differ. Signed-off-by: Ioannis Sfakianakis <[email protected]>
jsfakian
force-pushed
the
BUG-CI349-checksum-mismatch
branch
from
9d1f5ae to
99af741
Compare
Comment on lines
+415
to
+417
| // Retrying the download due to image verification failure | ||
| // This happens when: RefCount and retryCount is non-zero, | ||
| // and DownloaderStatus state is "downloaded" |
There was a problem hiding this comment.
Shouldn't this comment move up to where the new code is?
eriknordmark
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.